Fix N_hits issue & fill AHDC::track bank before KF#1137
Merged
baltzell merged 3 commits intoJeffersonLab:developmentfrom Mar 10, 2026
Merged
Fix N_hits issue & fill AHDC::track bank before KF#1137baltzell merged 3 commits intoJeffersonLab:developmentfrom
baltzell merged 3 commits intoJeffersonLab:developmentfrom
Conversation
Contributor
zyzhangjlab
commented
Mar 5, 2026
- Fix the issue that there are events with number of hits < 6.
- fill chi2, sum_adc, path and dEdx in AHDC::track bank before Kalman Filter.
Collaborator
|
I made some review. The idea is that, if a quantity can be calculated, we should not have a setter for it. Example: We should make a choice. Whether we compute everything, whether we set everything. As a consequence, some variables are left non used. |
Collaborator
|
@ftouchte et.al, if you think this should be merged, please approve it. |
ftouchte
approved these changes
Mar 6, 2026
Collaborator
|
just need to get the fork branch up to date in order to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.